On Sun, 19 May 2024 23:00:36 +0200 Dimitri Fedrau <dima.fedrau@xxxxxxxxx> wrote: > Am Sun, May 19, 2024 at 05:42:48PM +0100 schrieb Jonathan Cameron: > > On Fri, 17 May 2024 10:10:50 +0200 > > Dimitri Fedrau <dima.fedrau@xxxxxxxxx> wrote: > > > > > The device has four programmable temperature alert outputs which can be > > > used to monitor hot or cold-junction temperatures and detect falling and > > > rising temperatures. It supports up to 255 degree celsius programmable > > > hysteresis. Each alert can be individually configured by setting following > > > options in the associated alert configuration register: > > > - monitor hot or cold junction temperature > > > - monitor rising or falling temperature > > > - set comparator or interrupt mode > > > - set output polarity > > > - enable alert > > > > > > This patch binds alert outputs to iio events: > > > - alert1: hot junction, rising temperature > > > - alert2: hot junction, falling temperature > > > - alert3: cold junction, rising temperature > > > - alert4: cold junction, falling temperature > > > > > > All outputs are set in comparator mode and polarity depends on interrupt > > > configuration. > > > > > > Signed-off-by: Dimitri Fedrau <dima.fedrau@xxxxxxxxx> > > Hi Dmitri > > Hi Jonathan, > > > Please make sure to address all questions in earlier reviews, either by > > changing the code, or directly answering the question. > > > I did, see: https://lore.kernel.org/linux-iio/20240509204559.GB3614@debian/T/#u > or did I miss anything ? I'm a little bit confused. I think some emails went astray :( Sorry I didn't check the archive. Anyhow, thanks for providing the links. Jonathan
