On 13/05/2024 16:35, Arthur Becker wrote: > This commit adds device tree bindings for the veml6040 RGBW Light Sensor Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 More importantly: where is the driver or any other user of this binding? Why this is sent alone? > > signed-off-by: Arthur Becker <arthur.becker@xxxxxxxxxx> > --- ... > + > + reg: > + description: > + I2C address of the device. Drop description, redundant. > + enum: > + - 0x10 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@10 { > + compatible = "vishay,veml6040"; Messed indentation. > + reg = <0x10>; > + }; > + }; > +... Best regards, Krzysztof
