On Sun, 12 May 2024 13:41:51 +0200 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > Hello Jonathan, > > On Sat, May 11, 2024 at 02:20:06PM +0100, Jonathan Cameron wrote: > > On Wed, 8 May 2024 09:29:27 +0200 > > Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > > > > These drivers don't use the driver_data member of struct i2c_device_id, > > > so don't explicitly initialize this member. > > > > > > This prepares putting driver_data in an anonymous union which requires > > > either no initialization or named designators. But it's also a nice > > > cleanup on its own. > > > > > > While add it, also remove commas after the sentinel entries. > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > --- > > > Hello, > > > > > > I didn't add all the individual maintainers to Cc and put the iio changes in a > > > single patch. If you want I can split per driver (or per iio subdirectory?), > > > just tell me if you prefer it that way. > > > > I don't mind a single patch as resolving any backporting issues around this > > should be easy. > > *nod* > > > Whilst your changes for driver_data in struct i2c_device_id obviously don't > > need it, maybe it's worth similar patches to cleanup acpi_device_id and > > of_device_id tables with pointless 0 initialisation? > > Yup, I'm aware of these. I'll tackle them once I'm through with i2c. > > > Applied this with some conflicts in bmi160 resolved by hand. > > > > Applied to the togreg branch of iio.git but only pushed out for now as testing > > to let 0-day look at it. I'll rebase on 6.10-rc1 once available. > > Sounds good. I didn't find a public branch on > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/ that > contains your adaption of my patch. Otherwise I'd have double checked > your conflict resolution. Feel free to tell me once it's there (or where > I missed it). > Got distracted and didn't push out :( Anyhow, should be there shortly on the testing branch. Thanks, Jonathan > Best regards > Uwe >
