On Fri, May 10, 2024 at 05:00:59PM +0800, Chen Ni wrote:
> As the potential failure of the clk_enable(), it should be better to
> check it and return error if fails.
>
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
> ---
> drivers/counter/ti-ecap-capture.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/counter/ti-ecap-capture.c b/drivers/counter/ti-ecap-capture.c
> index 675447315caf..30a269fa5da0 100644
> --- a/drivers/counter/ti-ecap-capture.c
> +++ b/drivers/counter/ti-ecap-capture.c
> @@ -574,8 +574,11 @@ static int ecap_cnt_resume(struct device *dev)
> {
> struct counter_device *counter_dev = dev_get_drvdata(dev);
> struct ecap_cnt_dev *ecap_dev = counter_priv(counter_dev);
> + int ret;
>
> - clk_enable(ecap_dev->clk);
> + ret = clk_enable(ecap_dev->clk);
> + if (ret)
> + return ret;
>
> ecap_cnt_capture_set_evmode(counter_dev, ecap_dev->pm_ctx.ev_mode);
>
> --
> 2.25.1
Hi Chen,
Would you add a Fixes tag so we can pick this up for the stable kernels
too?
Thanks,
William Breathitt Gray
Attachment:
signature.asc
Description: PGP signature
