Hi guys! I am sending this e-mail as a reply to [1] I know I am not included in the mailing list, but since I am working on that driver currently [2] and I am also reading daily the iio mailing list I found your patch quite interesting and I wanted to test it. I managed to generate a negative temperature for the sensor and as it looks like you are right. Before your patch, the return value was overflowing for negative temperatures. So, good job! I have one question though: 1) The comment that includes the "milli Celsius" is also similar in the bmp380_read_temp() function so maybe you could change both. But since it is a fixes patch, is that necessary to be done in this commit? [1]: https://lore.kernel.org/linux-iio/Zin2udkXRD0+GrML@xxxxxxxxxxxxxx/ [2]: https://lore.kernel.org/linux-iio/20240429190046.24252-1-vassilisamir@xxxxxxxxx/ P.S: I don't know how tags work, but if for the tested tag the testing that I did is enough, then here is my tag: Tested-By: Vasileios Amoiridis <vassilisamir@xxxxxxxxx>
