Hi Dimitri, kernel test robot noticed the following build errors: [auto build test ERROR on jic23-iio/togreg] [also build test ERROR on linus/master v6.9-rc6 next-20240430] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dimitri-Fedrau/iio-temperature-mcp9600-set-channel2-member/20240430-200914 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg patch link: https://lore.kernel.org/r/20240430120535.46097-6-dima.fedrau%40gmail.com patch subject: [PATCH 5/5] iio: temperature: mcp9600: add threshold events support config: i386-buildonly-randconfig-005-20240501 (https://download.01.org/0day-ci/archive/20240501/202405010420.2KNGPYh5-lkp@xxxxxxxxx/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240501/202405010420.2KNGPYh5-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202405010420.2KNGPYh5-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/iio/temperature/mcp9600.c: In function 'mcp9600_probe_alerts': >> drivers/iio/temperature/mcp9600.c:407:28: error: implicit declaration of function 'irq_get_trigger_type' [-Werror=implicit-function-declaration] 407 | irq_type = irq_get_trigger_type(irq); | ^~~~~~~~~~~~~~~~~~~~ >> drivers/iio/temperature/mcp9600.c:408:33: error: 'IRQ_TYPE_EDGE_RISING' undeclared (first use in this function) 408 | if (irq_type == IRQ_TYPE_EDGE_RISING) | ^~~~~~~~~~~~~~~~~~~~ drivers/iio/temperature/mcp9600.c:408:33: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors vim +/irq_get_trigger_type +407 drivers/iio/temperature/mcp9600.c 382 383 static int mcp9600_probe_alerts(struct iio_dev *indio_dev) 384 { 385 struct mcp9600_data *data = iio_priv(indio_dev); 386 struct i2c_client *client = data->client; 387 struct device *dev = &client->dev; 388 struct fwnode_handle *fwnode = dev_fwnode(dev); 389 unsigned int irq_type; 390 int ret, irq, i; 391 u8 val; 392 393 /* 394 * alert1: hot junction, rising temperature 395 * alert2: hot junction, falling temperature 396 * alert3: cold junction, rising temperature 397 * alert4: cold junction, falling temperature 398 */ 399 for (i = 0; i < MCP9600_ALERT_COUNT; i++) { 400 data->irq[i] = 0; 401 mutex_init(&data->lock[i]); 402 irq = fwnode_irq_get_byname(fwnode, mcp9600_alert_name[i]); 403 if (irq <= 0) 404 continue; 405 406 val = 0; > 407 irq_type = irq_get_trigger_type(irq); > 408 if (irq_type == IRQ_TYPE_EDGE_RISING) 409 val |= MCP9600_ALERT_CFG_ACTIVE_HIGH; 410 411 if (i == MCP9600_ALERT2 || i == MCP9600_ALERT4) 412 val |= MCP9600_ALERT_CFG_FALLING; 413 414 if (i == MCP9600_ALERT3 || i == MCP9600_ALERT4) 415 val |= MCP9600_ALERT_CFG_COLD_JUNCTION; 416 417 ret = i2c_smbus_write_byte_data(client, 418 MCP9600_ALERT_CFG(i + 1), 419 val); 420 if (ret < 0) 421 return ret; 422 423 ret = devm_request_threaded_irq(dev, irq, NULL, 424 mcp9600_alert_handler, 425 IRQF_ONESHOT, "mcp9600", 426 indio_dev); 427 if (ret) 428 return ret; 429 430 data->irq[i] = irq; 431 } 432 433 return 0; 434 } 435 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki