On Tue, Apr 30, 2024 at 07:29:44PM +0300, Alisa-Dariana Roman wrote: > Devices that have both single-ended channels and differential channels > cause a bit of confusion when the channels are configured in the > devicetree. > > Clarify difference between these two types of channels for such devices > by adding single-channel property alongside diff-channels. They should > be mutually exclusive. I think that this mutual exclusion and the requirement for reg in the absence of either property should be enforced by the binding, not described in a commit message or free-form text in the property description. > > Devices that have only single-ended channels can still use reg property > to reference a channel like before. > > Suggested-by: Jonathan Cameron <jic23@xxxxxxxxxx> > Signed-off-by: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/iio/adc/adc.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml > index 36775f8f71df..0c3eae580732 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml > @@ -38,6 +38,14 @@ properties: > The first value specifies the positive input pin, the second > specifies the negative input pin. > > + single-channel: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + When devices combine single s/single/single-ended/, no? Cheers, Conor. > and differential channels, allow the channel > + for a single element to be specified, independent of reg (as for > + differential channels). If this and diff-channels are not present reg > + shall be used instead. > + > settling-time-us: > description: > Time between enabling the channel and first stable readings. > -- > 2.34.1 >
Attachment:
signature.asc
Description: PGP signature