On Thu, 25 Apr 2024 10:03:26 -0500 David Lechner <dlechner@xxxxxxxxxxxx> wrote: > While working on other patches I noticed that a few drivers are setting > the masklength field of struct iio_dev even though it is marked as > [INTERN]. It looks like maybe this was not always the case, but we can > safely clean it up now without breaking anything. > > --- > David Lechner (3): > iio: adc: ad7266: don't set masklength > iio: adc: mxs-lradc-adc: don't set masklength > iio: buffer: initialize masklength accumulator to 0 > > drivers/iio/adc/ad7266.c | 1 - > drivers/iio/adc/mxs-lradc-adc.c | 1 - > drivers/iio/industrialio-buffer.c | 2 +- > 3 files changed, 1 insertion(+), 3 deletions(-) Applied to the togreg branch of iio.git and pushed out as testing for 0-day to poke at it. I can't remember that ever being set by drivers so this is rather weird. Mind you our docs used to be less clear on what drivers should set so maybe that was the issue. Jonathan > --- > base-commit: b80ad8e3cd2712b78b98804d1f59199680d8ed91 > change-id: 20240425-b4-iio-masklength-cleanup-86b632b19901 >