On Wed, 17 Apr 2024 20:06:00 +0300
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> On Wed, Apr 17, 2024 at 8:01 PM Alisa-Dariana Roman
> <alisadariana@xxxxxxxxx> wrote:
> >
> > Unlike the other AD719Xs, AD7194 has configurable differential
> > channels. The user can dynamically configure them in the devicetree.
> >
> > Also modify config AD7192 description for better scaling.
>
> ...
>
> > + device_for_each_child_node(dev, child) {
>
> You can use scoped variant AFAIU that's available in Jonathan's tree.
>
> > + *ad7194_channels = ad7194_chan_diff;
> > + ad7194_channels->scan_index = index++;
> > + ret = ad7194_parse_channel(child, ad7194_channels);
> > + if (ret) {
>
> > + fwnode_handle_put(child);
>
> With the above this wouldn't be needed.
>
As it's a minor improvement, and I tend not to like unnecessary
interdependence of series in my tree (until they are in char-misc
and hence no chance of them changing), I'm fine with not using
that new functionality here.
That will change once it's upstream of course!
I will send a pull request to Greg nice and early this cycle
so that should be in my upstream soon.
I'm also fine with you using this if you want to though!
Jonathan
> > + return ret;
> > + }
> > + ad7194_channels++;
> > + }
>
