Re: [PATCH v3 07/10] dt-bindings: iio: dac: add docs for AD9739A

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2024-04-12 at 18:47 -0500, David Lechner wrote:
> On Fri, Apr 12, 2024 at 8:36 AM Nuno Sa via B4 Relay
> <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote:
> > 
> > From: Nuno Sa <nuno.sa@xxxxxxxxxx>
> > 
> 
> ...
> 
> > +  adi,full-scale-microamp:
> > +    description: This property represents the DAC full scale current.
> 
> The description could be improved by saying what determines the value
> that need to be entered here. (Also wondering if this is not something
> that should be set at runtime using the _scale attribute instead.)
> 

Hmm, not sure what you mean here? For anyone using a device like this, it should
be clear what this is about :)

> > +    minimum: 8700
> > +    maximum: 31700
> 
> Missing a default value since this is not a required property?
> 

Hmm, yes. That could definitely be added.

- Nuno Sá
> 





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux