On Sun, 14 Apr 2024 18:19:02 +0200 Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote: > On Sat, Apr 13, 2024 at 05:52:57PM +0100, Jonathan Cameron wrote: > > On Sun, 7 Apr 2024 19:29:15 +0200 > > Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote: > > > > > Various driver cleanups including: > > > > > Not sure how we got to a v4 with a patch title various. > > > > If you have to list multiple changes, it should normally > > be multiple patches. > > > > White space can all be grouped, but the others should be separate. > > Please break it up for v5. > > > > I'll take a look at the actual changes even though I won't merge > > a 'various' patch like this. > > > > I may well miss things because there is simply too much in here > > and some of the diffs are subtle as it can be hard to spot > > if it's a name change or a functional change. > > > > Hi Jonathan, > > Thank you once again for the very valuable feedback! We didn't actually > reached v4 with a title various. It is just that the more that I was > working on this driver the more things I noticed that could be cleaned > (apparently not all of them as you mentioned) but still quite some that > could be cleaned. So I took the opportunity before adding the triggered > buffer support to do this cleaning. > > The reason that I did it in a big patch is that in a previous version > of this set of patches, you mentioned that we must find a way to make > the commits less, so that's why I thought that a cleaning patch could > include many different types of cleaning since there are no functional > changes but as I understand that's not the case, so I will split them > for v5. Ah. I was interested in reducing overhead of having the same change that everyone was happy with being posted in lots of versions due to other changes later in the series. Not reducing number of patches overall! BTW I picked up the header sorting in v3 so you don't need to carry that change any more. Jonathan
