On Mon, 2024-04-01 at 08:59 -0500, Rob Herring wrote: > On Thu, Mar 28, 2024 at 02:22:30PM +0100, Nuno Sa wrote: > > This adds the bindings documentation for the AXI DAC driver. > > Bindings are for h/w blocks, not 'drivers'. > > Reword the subject to only say 'bindings' once. > > > > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > > --- > > .../devicetree/bindings/iio/dac/adi,axi-dac.yaml | 62 > > ++++++++++++++++++++++ > > MAINTAINERS | 7 +++ > > 2 files changed, 69 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml > > b/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml > > new file mode 100644 > > index 000000000000..1018fd274f04 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml > > @@ -0,0 +1,62 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/dac/adi,axi-dac.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices AXI DAC IP core > > + > > +maintainers: > > + - Nuno Sa <nuno.sa@xxxxxxxxxx> > > + > > +description: | > > + Analog Devices Generic AXI DAC IP core for interfacing a DAC device > > + with a high speed serial (JESD204B/C) or source synchronous parallel > > + interface (LVDS/CMOS). > > + Usually, some other interface type (i.e SPI) is used as a control > > + interface for the actual DAC, while this IP core will interface > > + to the data-lines of the DAC and handle the streaming of data into > > + memory via DMA. > > + > > + https://wiki.analog.com/resources/fpga/docs/axi_dac_ip > > + > > +properties: > > + compatible: > > + enum: > > + - adi,axi-dac-9.1.b > > + > > + reg: > > + maxItems: 1 > > + > > + dmas: > > + maxItems: 1 > > + > > + dma-names: > > + items: > > + - const: tx > > You don't need *-names if there is only 1 entry. Looking at the dmaengine code [1], it actually looks like I should have this property required, no? [1]: https://elixir.bootlin.com/linux/v6.9-rc2/source/drivers/dma/of-dma.c#L270 - Nuno Sá
