On Fri, 29 Mar 2024 15:49:26 +0000 Conor Dooley <conor@xxxxxxxxxx> wrote: > On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@xxxxxxx wrote: > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx> > > > > Add bindings for ICM-42688-P chip. > > > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx> > > My initial thought was that you're missing a sign-off, but is > "inv.git-commit@xxxxxxx" some system you have to bypass corporate email > garbage? Common enough setup, as long as the From: line matches the sign-off, git will ignore the email address used to send it when the patch is applied. > > > --- > > .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > > index 7cd05bcbee31..152aec8d82ff 100644 > > --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > > @@ -31,6 +31,7 @@ properties: > > - invensense,icm42602 > > - invensense,icm42605 > > - invensense,icm42622 > > + - invensense,icm42688 > > Can you add this in alphanumerical order please? > > Also, this patch should be the first in the series. Agreed on both, otherwise this series LGTM Jonathan > > Thanks, > Conor. > > > - invensense,icm42631 > > > > reg: > > -- > > 2.34.1 > >
