On Tue, 19 Mar 2024 01:29:24 +0100 Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote: > The scan mask for the BME280 supports humidity measurement and > needs to be distinguished from the rest in order for the timestamp > to be able to work. This needs a rewrite. I read that as the measurement needed to be distinguished from other measurements, not the device needs to be distinguished from other devices. It's also unusual to update the scan masks to add timestamps or scan_index / scan_type before they are actually used. Hence this first patch should just split the definitions but not add the additional elements until the next patch that adds buffered support (where these get used). So resulting code is fine, but the patch breakup can be improved so all the bits we need to look at for a given feature are in a single patch (but not the refactoring). Jonathan
