On Wed, Mar 20, 2024 at 10:34 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 19/03/2024 22:27, Lothar Rubusch wrote: > > Provide the optional spi-3wire option for the DT binding. > > > > Signed-off-by: Lothar Rubusch <l.rubusch@xxxxxxxxx> > > A nit, subject: drop second/last, redundant "documentation". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > Also, everything is an update. Be descriptive. Ok > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. Yes. Next time I'll chose better prefixes. For now I keep the subject to the mail to not break the mailing thread and update the patches in a follow up. I hope this is ok? > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline), work on fork of kernel > (don't, instead use mainline) or you ignore some maintainers (really > don't). Just use b4 and everything should be fine, although remember > about `b4 prep --auto-to-cc` if you added new patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time, thus I will skip this patch entirely till you follow > the process allowing the patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. > > Best regards, > Krzysztof I understand. I took linux-next. I fetched it this week from mainline kernel.org. I took "get_maintainers.pl" as a mere recommendation rather than mandatory and skipped most of the emails. Sry for that. Thank you for all the information.
