I missed the reply-all on my last reply, so adding back this lists for the record. On Thu, Mar 14, 2024 at 10:57 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > On Thu, 14 Mar 2024 10:52:57 -0500 > David Lechner <dlechner@xxxxxxxxxxxx> wrote: > > > On Wed, Mar 13, 2024 at 3:28 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote: > > > > ... > > > > > +AD7944 and AD7985 are pseudo-differential ADCs and have the following attributes: > > > + > > > ++---------------------------------------+--------------------------------------------------------------+ > > > +| Attribute | Description | > > > ++=======================================+==============================================================+ > > > +| ``in_voltage0_raw`` | Raw ADC voltage value (*IN+* referenced to ground sense). | > > > ++---------------------------------------+--------------------------------------------------------------+ > > > +| ``in_voltage0_scale`` | Scale factor to convert raw value to mV. | > > > ++---------------------------------------+--------------------------------------------------------------+ > > > + > > > > A colleague pointed out that it is perhaps a bit unusual to have > > per-channel scaling since the scale is determined by a single > > reference voltage. I guess it is OK here since there is only one > > channel. But the driver hasn't hit mainline yet, so we could change > > that if you think it is better to have a "shared" `in_voltage_scale`. > Lots of devices have per channel scaling (amplifiers on the front end) but > on a single channel device, it could be shared or per channel without > it making any practical difference. > > It's unusual, but not wrong, so I'm not that fussed either way. > > > > > ... > > > > > + > > > +Show voltage input channel values: > > > + > > > +.. code-block:: console > > > + > > > + root:/sys/bus/iio/devices/iio:device0# cat voltage0-voltage1_raw > > > + -101976 > > > + root:/sys/bus/iio/devices/iio:device0# cat voltage0-voltage1_scale > > > + 0.038146972 > > > + > > > > Typo here. Missing `in_` on the attribute name. >
