Re: [PATCH v4 1/2] dt-bindings: iio: adc: add ad7944 ADCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, 29 Feb 2024 10:25:50 -0600
David Lechner <dlechner@xxxxxxxxxxxx> wrote:

> This adds a new binding for the Analog Devices, Inc. AD7944, AD7985, and
> AD7986 ADCs.
> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
Hi David,

One trivial comment. If this is all that comes up I can tweak that whilst applying.



> +  adi,spi-mode:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [ single, chain ]
> +    description: |
> +      This property indicates the SPI wiring configuration.
> +
> +      When this property is omitted, it is assumed that the device is using what
> +      the he datasheet calls "4-wire mode". This is the conventional SPI mode

Stray "he"?

> +      used when there are multiple devices on the same bus. In this mode, the
> +      CNV line is used to initiate the conversion and the SDI line is connected
> +      to CS on the SPI controller.

[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     []

  Powered by Linux