On Tue, Feb 27, 2024 at 06:37:53PM +0100, Fabrice Gasnier wrote:
> Now that there are two users for the "frequency" extension, introduce a
> new COUNTER_COMP_FREQUENCY() macro.
>
> Suggested-by: William Breathitt Gray <william.gray@xxxxxxxxxx>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
> ---
> include/linux/counter.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/counter.h b/include/linux/counter.h
> index 702e9108bbb4..03472d7407de 100644
> --- a/include/linux/counter.h
> +++ b/include/linux/counter.h
> @@ -602,6 +602,9 @@ struct counter_array {
> #define COUNTER_COMP_FLOOR(_read, _write) \
> COUNTER_COMP_COUNT_U64("floor", _read, _write)
>
> +#define COUNTER_COMP_FREQUENCY(_read, _write) \
> + COUNTER_COMP_SIGNAL_U64("frequency", _read, _write)
> +
> #define COUNTER_COMP_POLARITY(_read, _write, _available) \
> { \
> .type = COUNTER_COMP_SIGNAL_POLARITY, \
> --
> 2.25.1
Sorry, would you make one minor change? The "frequency" extension is
read-only so there is no need for a _write parameter (it'll always be
NULL).
You don't need to rebase and submit the entire patchset again just yet
because I will likely have more comments when I review. Just submit the
next version of this particular patch separately and I'll pick it up so
we can get it merged into counter-next.
Thanks,
William Breathitt Gray
Attachment:
signature.asc
Description: PGP signature
