On Wed, Feb 28, 2024 at 6:26 AM Alisa-Dariana Roman <alisadariana@xxxxxxxxx> wrote: > > Unlike the other AD719Xs, AD7194 has configurable differential > channels. The default configuration for these channels can be changed > from the devicetree. > > Also add an example for AD7194 devicetree. > > Signed-off-by: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx> > Signed-off-by: romandariana <alisa.roman@xxxxxxxxxx> Why two SOBs with the same email? > --- > .../bindings/iio/adc/adi,ad7192.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > index 16def2985ab4..c62862760311 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > @@ -21,8 +21,15 @@ properties: > - adi,ad7190 > - adi,ad7192 > - adi,ad7193 > + - adi,ad7194 > - adi,ad7195 > > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > reg: > maxItems: 1 > Based on the discussion in v3, I was expecting to see an aincom-supply property added. (Although that probably belongs in a separate patch since it applies to all existing chips, not just the one being added here.) > @@ -96,8 +103,44 @@ required: > - spi-cpol > - spi-cpha > > +patternProperties: > + "^channel@([0-9]+)$": > + type: object > + $ref: adc.yaml > + unevaluatedProperties: false > + > + properties: > + reg: > + description: The channel index. > + minimum: 1 > + maximum: 16 I guess this is OK, but max of 16 is a bit artificial since there could be unusual use cases where inputs are reused on multiple channels. Technically, there are 16 * 17 = 272 possible combinations that could appear.
