Re: [PATCH v5 1/9] iio: temp: ltc2983: Use __free(fwnode_handle) and device_for_each_node_scoped()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2024-02-26 at 19:30 +0000, Jonathan Cameron wrote:
> On Mon, 26 Feb 2024 09:35:49 +0100
> Nuno Sá <noname.nuno@xxxxxxxxx> wrote:
> 
> > On Sat, 2024-02-24 at 12:32 +0000, Jonathan Cameron wrote:
> > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > > 
> > > This use of the new cleanup.h scope based freeing infrastructure allows
> > > us to exit directly from error conditions and in the good path with
> > > the reference obtained from fwnode_find_reference() (which may be an error
> > > pointer) automatically released.
> > > 
> > > Similarly the _scoped() version of device_for_each_child_node()
> > > removes the need for the manual calling of fwnode_handl_put() in
> > > paths where the code exits the loop early.
> > > 
> > > Tidy up some unusual indentation in a dev_dbg() whilst here.
> > > 
> > > Cc: Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>
> > > Cc: Nuno Sá <nuno.sa@xxxxxxxxxx>
> > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > > 
> > > ---
> > > v5: Add the device_for_each_child_node_scoped() change (Nuno)
> > > ---  
> > 
> > Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
> I'll pick up this now as whilst I hope someone will check the others, I know
> you are building on this and it will make life easier if this is already
> queued up.
> 

Thanks,

Will work on top of that for my series.

- Nuno Sá





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux