Re: [PATCH 3/3] iio: adc: rockchip_saradc: replace custom logic with devm_reset_control_get_optional_exclusive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Andy and Quentin,

On 2024-02-23 15:39, Andy Shevchenko wrote:
On Fri, Feb 23, 2024 at 3:10 PM Quentin Schulz
<quentin.schulz@xxxxxxxxxxxxxxxxxxxxx> wrote:
On 2/23/24 14:00, Andy Shevchenko wrote:
> On Fri, Feb 23, 2024 at 2:46 PM Quentin Schulz <foss+kernel@xxxxxxxxx> wrote:

...

>> Cc: Quentin Schulz <foss+kernel@xxxxxxxxx>
>
> You may use the --cc option to `git send-email` instead of polluting
> commit messages, or move this after the '---' cutter line.

The whole point is that my SoB and authorship is from my professional
mail address which is likely to change over time, the Cc is my personal one for development. Basically, in the event that I change my employer,
I would still be reachable at that Cc address without having to modify
the .mailmap after the fact (which won't make it to an earlier version
of the kernel for example). Some maintainers don't really like this,
some don't mind, we'll see in which category the IIO maintainer(s) fall
in :) (I don't mind either way just to be clear).

My point is that Cc and other similar (non-real-tags) stuff is
polluting commit messages. It means that this will be copied to the
Git index to all kernel git repositories in the world from now and
then, This is at bare minimum makes additional burden on git log (and
parsing and so on) and moreover, wastes resources becoming less
environment friendly (no jokes). Using --cc or moving to the behind
the commit message will keep email copied with cleaner commit
messages. Yet, all email tags are available in lore archive
(lore.kernel.org). Please, really reconsider the commit messages
content in the Linux kernel project and elsewhere, it will help to
make the world more friendly.

Believe it or not, I'm working on some patches for Git that, I believe,
should help a lot when it comes to handling Cc: addresses.  Would you
like to be included in the list of recipients for those Git patches, so
you could, hopefully, provide some feeback?




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux