On Mon, 19 Feb 2024 14:06:54 +0200 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Sun, Feb 18, 2024 at 05:27:23PM +0000, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > Andy pointed out that some of the drivers I was using as examples for > > "[PATCH 0/8] of: automate of_node_put() - new approach to loops." > > should be converted over to fwnode / property.h based handling anyway > > at which point the device_for_each_child_node_scoped() handler could be > > used instead. He correctly observed that it made more sense to make this > > transition directly than to improve the device tree specific handling. > > > > So this series does that and also some of the other drivers that were still > > using device tree specific handling. Note the rcar-adc remains DT > > specific due to it directly handling maching against of_device_id tables. > > It probably doesn't make sense to move that custom handling over to > > fwnode. > > > > I included one devm_ cleanup patch in here as I was touching the > > driver anyway. > > > > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Thank you! > I have some minor comments, but in general I like this series, > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Applied with various suggestions acted on (even if that is asking Nuno to send a patch to tidy them up at a later date :) Applied to the togreg branch of iio.git and pushed out as testing to see what I missed. Thanks, Jonathan
