RE: [PATCH 6/8] iio: accel: mma8452: Switch from of specific to fwnode property handling.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: 2024年2月19日 1:27
> To: linux-iio@xxxxxxxxxxxxxxx; Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>; Michael Hennerich
> <Michael.Hennerich@xxxxxxxxxx>; Nuno Sá <nuno.sa@xxxxxxxxxx>;
> Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx>; Bough Chen
> <haibo.chen@xxxxxxx>; Sean Nyekjaer <sean@xxxxxxxxxx>; Andreas Klinger
> <ak@xxxxxxxxxxxxx>; Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Subject: [PATCH 6/8] iio: accel: mma8452: Switch from of specific to fwnode
> property handling.
> 
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> 
> In this case only use was to get an irq so easily converted.
> Also include linux/mod_devicetable.h for struct of_device_id definition.
> 
> Using the generic firmware handling, this driver may be used with other
> firmware types. This also removes an example that might get copied into other
> drivers leaving them unable to be used with alternative firmware types.
> 
> Cc: Haibo Chen <haibo.chen@xxxxxxx>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Reviewed-and-tested-by: Haibo Chen <haibo.chen@xxxxxxx>

> ---
>  drivers/iio/accel/mma8452.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index
> d3fd0318e47b..62e6369e2269 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -19,6 +19,8 @@
>   */
> 
>  #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/property.h>
>  #include <linux/i2c.h>
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
> @@ -28,8 +30,6 @@
>  #include <linux/iio/triggered_buffer.h>  #include <linux/iio/events.h>
> #include <linux/delay.h> -#include <linux/of.h> -#include <linux/of_irq.h>
> #include <linux/pm_runtime.h>  #include <linux/regulator/consumer.h>
> 
> @@ -1642,7 +1642,7 @@ static int mma8452_probe(struct i2c_client *client)
>  	if (client->irq) {
>  		int irq2;
> 
> -		irq2 = of_irq_get_byname(client->dev.of_node, "INT2");
> +		irq2 = fwnode_irq_get_byname(dev_fwnode(&client->dev), "INT2");
> 
>  		if (irq2 == client->irq) {
>  			dev_dbg(&client->dev, "using interrupt line INT2\n");
> --
> 2.43.2





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux