Re: [PATCH v13 2/3] iio: adc: ad_sigma_delta: Add optional irq selection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/20/24 16:11, Andy Shevchenko wrote:
> On Tue, Feb 20, 2024 at 11:43:39AM +0200, Dumitru Ceclan wrote:
>> Add optional irq_num attribute to ad_sigma_delta_info structure for
>> selecting the used interrupt line for adc's conversion completion.
> 
> ...
> 
>> +	if (!info->irq_num)
>> +		sigma_delta->irq_num = spi->irq;
>> +	else
>> +		sigma_delta->irq_num = info->irq_num;
> 
> Why not positive check?
> 
Considered that selecting spi->irq is usually the default case, so it
should be the first branch




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux