On Mon, Feb 19, 2024 at 08:51:45PM +0100, Vasileios Amoiridis wrote: > On Mon, Feb 19, 2024 at 07:42:36PM +0000, Jonathan Cameron wrote: > > On Mon, 19 Feb 2024 20:13:59 +0100 > > Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote: > > > > > According to the datasheet of BMP38x and BMP390 devices, for an SPI > > > read operation the first byte that is returned needs to be dropped, > > > and the rest of the bytes are the actual data returned from the > > > sensor. > > > > > > Fixes: 8d329309184d ("iio: pressure: bmp280: Add support for BMP380 sensor family") > > No line break. The fixes tag is part of the main tag block. > > I can fix that whilst applying. > > Otherwise this looks fine to me. > > > > I'll leave it on list a little longer though as both Linus and Angel > > are still about and might have time to also take a look at this. > > > > Thank you very much again for the quick answer. Since you can fix it while applying, > I should not annoy the mailing list with more e-mails. Just for future reference, > when you mean no line break you mean between the main block and the "Fixes" line > or between the "Fixes" line and the "Signed-off-by: ...." ? > > > > > > Signed-off-by: Vasileios Amoiridis <vassilisamir@xxxxxxxxx> The standard pattern for the patch (as it is seen in the `git log`): ---8<--- iio: ...Subject line, summary of the change... BLANK LINE ...Multi-line description, may contain blank lines... BLANK LINE ...Tag block: SoB, Rb, etc. tags (may NOT contain blank lines)... ---8<--- -- With Best Regards, Andy Shevchenko