On Sun, Feb 18, 2024 at 05:27:28PM +0000, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Enables use of with other firmwware types. > Removes a case of device tree specific handlers that might get copied > into new drivers. ... > - dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X != 0x%X)\n", > + dev_warn(dev, "device ID query failed (0x%X != 0x%X)\n", > id, st->chip_info->chip_id); Now id can be moved to the previous line (but it's up to you as you may argue that this is the logical split). ... > - burnout_curr_en = of_property_read_bool(np, > - "adi,burnout-currents-enable"); > + burnout_curr_en = device_property_read_bool(dev, > + "adi,burnout-currents-enable"); Same pattern as in the other patch? burnout_curr_en = device_property_read_bool(dev, "adi,burnout-currents-enable"); -- With Best Regards, Andy Shevchenko
