On Fri, 16 Feb 2024 19:45:07 +0100 Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Hi, > > On 2/16/24 19:16, Jonathan LoBue wrote: > > From: Jonathan LoBue <jlobue10@xxxxxxxxx> > > > > This patch series adds comments about a duplicate ACPI identifier > > between devices using bmc150 and bmi323. This series also adds the ACPI > > match table for devices using bmi323 to allow those devices to load the > > proper driver. > > > > Changes since v5: > > - Updated patch titles > > - Add patch description to cover letter > > I have just tested this on a Chuwi Hi13 tablet with > a BOSC0200 accel. I blacklisted the bmc150 driver so that > the bmi323 driver would load first. The bmi323 driver > "successfully" fails to probe and after manually loading > the bmc150 driver (to fake a module loading order of > the bmi323 driver loading before the bmc150) the accel > works properly. > > So from my pov this series is good to go: > > Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > Regards, > Thanks. I've tweaked these a fair bit for minor things whilst applying. 1) Author (From: in the email) didn't match sign off. Given address was the same I think I'm fine to just fix that up. 2) All the lines had a leading space. Deleted those. 3) quite a few lines went just over 80 chars - I've rewrapped the comments to avoid this. Anyhow, with those tweaks, applied via the slow path (it's not a fix as such as the right driver was never loaded) but I'm fine with a request for a backport of this to older kernels after this is upstream (next merge window). Some of those would have been caught be scripts/checkpatch.pl - make sure you run that and either fix ever warning or have a good reason why not (there are often good reasons so don't take that script as a rule book!) Applied to the togreg branch of iio.git but initially only pushed out as testing for 0-day to get a head start checking for anything we missed. Thanks, Jonathan > Hans > > > >
