On Fri, 16 Feb 2024 12:23:48 +0100
Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote:
> On 24-02-16, Jonathan Cameron wrote:
> > On Fri, 16 Feb 2024 11:28:19 +0100
> > Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote:
> >
> > > From: Thomas Haemmerle <thomas.haemmerle@xxxxxxxxxxxxxxxxxxxx>
> > >
> > > Add the binding to specify the vcc supply. We can't make it required
> > > since this would break the backward compatibility.
> >
> > Given convention for supplies like this is to make them required in
> > the dt-binding to reflect that providing power is not optional (unlikely
> > some other supplies that might not be wired up) and not worry about the
> > fact that we happily provide dummy supplies for them if they aren't in a
> > particular dts, it should be fine to make it required here.
>
> Will this fact apply to all dt-bindings? I'm asking because, there are
> many bindings out there without having the -supply in place.
Yes in theory - in practice it's noise to do it unless we have a reason
to be touching the dt-binding anyway. I don't plan to fix them up on
mass.
Jonathan
>
> Regards,
> Marco
>
> >
> > Jonathan
> >
> > >
> > > Signed-off-by: Thomas Haemmerle <thomas.haemmerle@xxxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> > > ---
> > > Resend since I forgot to add the DT maintainers
> > >
> > > .../devicetree/bindings/iio/temperature/ti,tmp117.yaml | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> > > index 8c6d7735e875..cf7799c9734f 100644
> > > --- a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> > > @@ -24,6 +24,9 @@ properties:
> > > reg:
> > > maxItems: 1
> > >
> > > + vcc-supply:
> > > + description: provide VCC power to the sensor.
> > > +
> > > required:
> > > - compatible
> > > - reg
> > > @@ -39,5 +42,6 @@ examples:
> > > tmp117@48 {
> > > compatible = "ti,tmp117";
> > > reg = <0x48>;
> > > + vcc-supply = <&pmic_reg_3v3>;
> > > };
> > > };
> >
> >
