Hey, On Thu, Feb 08, 2024 at 07:24:58PM +0200, Alisa-Dariana Roman wrote: > +patternProperties: > + "^channel@([0-7a-f])$": > + type: object > + $ref: adc.yaml > + unevaluatedProperties: false > + > + properties: > + reg: > + description: The channel index. > + minimum: 0 > + maximum: 7 There are only 8 possible channels, at indices 0 to 7, so why is the pattern property more permissive than that? Shouldn't "^channel@[0-7]$" suffice? > + > + diff-channels: > + description: | > + The differential channel pair for Ad7194 configurable channels. The > + first channel is the positive input, the second channel is the > + negative input. This duplicates the description in adc.yaml > + items: > + minimum: 1 > + maximum: 16 Hmm, this makes me wonder: why doesn't this match the number of channels available and why is 0 not a valid channel for differential measurements? Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
