On Thu, 1 Feb 2024 13:38:16 +0200 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Wed, Jan 31, 2024 at 05:10:08PM +0100, Mike Looijmans wrote: > > On 13-12-2023 15:55, Andy Shevchenko wrote: > > > On Wed, Dec 13, 2023 at 10:47:22AM +0100, Mike Looijmans wrote: > > First of all, please remove unneeded context, don't make me waste time on doing > that for you! > > ... > > > > *val = sign_extend32(get_unaligned_be24(priv->rx_buffer + chan->address), > > > 23); > > > > Doesn't fit, first line is 83 characters by my count... > > Is it a problem? To add a bit more info here. For IIO at least (and most of the rest of the kernel) it's fine to go over 80 chars if there is a significant cost in readability to break the line. Here that is the case + you are only going 3 chars over so it's fine to do so. Jonathan > >
