On Mon, Jan 29, 2024 at 12:15 AM Nuno Sá <noname.nuno@xxxxxxxxx> wrote: > > On Sat, 2024-01-27 at 15:07 +0000, Jonathan Cameron wrote: > > On Wed, 24 Jan 2024 19:14:35 -0800 > > Saravana Kannan <saravanak@xxxxxxxxxx> wrote: > > > > > On Tue, Jan 23, 2024 at 7:14 AM Nuno Sa via B4 Relay > > > <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote: > > > > > > > > From: Nuno Sa <nuno.sa@xxxxxxxxxx> > > > > > > > > The property is io-channels and not io-channel. This was effectively > > > > preventing the devlink creation. > > > > I'm a bit lost on the devlink side of things. Is this something with > > effects on existing drivers before this patch set, or is it only causing > > real problems with the changes in here? > > > > i.e. Should we mark it for stable and rush it in as a fix, or can it wait > > for the rest of the set? > > > > I guess you already figured this out? Anyways, this is a real fix that was > affecting any consumer using io-channels (so nothing to do with the current > series). Since the there was a typo, no fw_links were being created. > > I stated in the cover why I included this. Just to make the addition of io- > backends later on easier. But if Rob prefers (or you), I can just send this > standalone patch to the devicetree list. I think you should send this to Rob directly as a DT fix. I already gave you a Reviewed-by too. So it should land quickly. This is a real bug that we want to fix as soon as we can. And your series might take a bit longer to land. -Saravana