On 22/01/2024 11:07, Subhajit Ghosh wrote: > On 22/1/24 20:21, Krzysztof Kozlowski wrote: >> On 21/01/2024 06:17, Subhajit Ghosh wrote: >>> Adding device tree support for APDS9306 Ambient Light Sensor. >>> Updating datasheet hyperlinks. >>> Adding interrupt definition macro and header file. >>> Adding vdd-supply property. >> >> Why? Do other devices have it? > Are you referring to vdd-supply? No, I guess, haven't checked actually. > If other devices don't have, can you suggest the best way to handle that? Commit msg should explain that. I assume all devices need it, so just like Jonathan suggested: this might be separate patch. Best regards, Krzysztof