On 22/1/24 01:57, Jonathan Cameron wrote:
On Sun, 21 Jan 2024 15:47:32 +1030
Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx> wrote:
Squashing Avago (Broadcom) APDS9300 and APDS9960 schemas into one
file and removing the other. This is done as per the below review:
Link: https://lore.kernel.org/all/4e785d2e-d310-4592-a75a-13549938dcef@xxxxxxxxxx/
Sounds like a Suggested-by tag to reflect the ideas would be sensible here.
This patch series adds the driver support and device tree binding schemas
for APDS9306 Ambient Light Sensor.
This sentence isn't relevant to this patch, so I'd drop it.
We don't need additional motivation.
It was pointed out in earlier reviews
that the schemas for APDS9300 and APDS9960 looks similar and should be
merged. This particular patch does the first operation of merging
APDS9300 and APDS9960 schema files.
You have a reference above which is enough.
"Merge very similar schemas for APDS9300 and APDS9960."
is sufficient description alongside a suggested by tag and if you like
a link tag to as above. Note however that Link is an official tag
so belongs in the tag block at the end, not inline in the text.
Link: ...
Thank you so much Jonathan for taking time to explain these things.
Regards,
Subhajit Ghosh
