On Sun, 2024-01-21 at 17:57 +0000, Jonathan Cameron wrote: > On Fri, 19 Jan 2024 17:00:46 +0100 > Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote: > > > > Changes in v6: > > - Patch 2 > > * Add '#io-backends-cells' property to the example dts. > > - Patch 6 > > * Improve comment on struct iio_backend_buffer_pair; > > * Be consistent with dots in kernel-docs. So dots only exist now in > > description and return. Also be consistent on device managed APIs > > subject and @dev description; > > * Added devm_iio_backend_enable() and hence (and for now) > > iio_backend_disable is static; > > * Fixed __devm_iio_backend_get_from_fwnode_lookup() kernel-doc; > > * Improved english in devm_iio_backend_register() comment; > > * Don't make private data mandatory; > > - Patch 7 > > * Use local ad9467_chip_info *info variable; > > * Improve error handling for optional devm_iio_backend_get(); > > * Make use of devm_iio_backend_enable(). > > - Patch 8 > > * Also change string format in version error path. > Hi Nuno, > > Other than wanting a few acks (one for 2nd DT patch with the fix and one > for the device link changes) this looks good to me. > > Ideally of course I'd like to see the second user if that happens to be > available in the first few weeks of this cycle, but I don't propose to hold > this indefinitely to wait for additional users as the framework seems logical > and it's all in kernel anyway so we can probably change whatever is needed > later without too much trouble. > Alright. I plan to start working on the next user already this week so let's see how it goes. - Nuno Sá >