On Tue, Jan 9, 2024 at 9:47 AM Nuno Sa <nuno.sa@xxxxxxxxxx> wrote:
>
> Respect the @dev argument in devm_iio_dmaengine_buffer_setup() and bind the
> IIO DMA buffer lifetime to that device.
>
> For the only user of this function, the IIO parent device is the
> struct device being passed to the API so no real fix in here (just
> consistency with other IIO APIs).
>
> Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
> ---
> drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> index 5f85ba38e6f6..45fe7d0d42ee 100644
> --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> @@ -279,8 +279,7 @@ int devm_iio_dmaengine_buffer_setup(struct device *dev,
> {
> struct iio_buffer *buffer;
>
> - buffer = devm_iio_dmaengine_buffer_alloc(indio_dev->dev.parent,
> - channel);
> + buffer = devm_iio_dmaengine_buffer_alloc(dev, channel);
> if (IS_ERR(buffer))
> return PTR_ERR(buffer);
>
>
> ---
> base-commit: 3f4525f924e21d4f532517b17a20ffa5df7c0db7
> change-id: 20240109-dmaengine_use_device-853f196ec78f
> --
>
> Thanks!
> - Nuno Sá
>
>
I noticed this too but didn't get around to fixing it yet. ;-)
Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>
