On Tue, 2 Jan 2024 01:48:07 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Sun, Dec 31, 2023 at 8:35 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > Many of these patches touch ancient drivers so the authors have long > > moved on to other things. As such I'd appreciate it if anyone has time > > to take a look! > > > > The initial part of this series deals with cases where unused variable > > warnings are generated with !CONFIG_ACPI but they most date back long > > enough to predate this being reported by lkp in general and the lkp folk > > have gotten push back not to push out such reports due to the high level > > of noise. I think some of these were reported to me directly on my > > Huawei.com account but aren't on lore.kernel.org. If I can easily > > track down appropriate closes tags I will add them when applying. > > > > The last few patches are for drivers that did have the right protections > > but where the usage was so trivial I'm not convinced they took the best > > approach. In the interests of not leaving cases of what I consider an > > undesirable pattern around for people to copy I have dropped the ACPI_PTR() > > usage and config guards from those as well. > > > > There are 3 remaining cases of ACPI_PTR() in IIO. In each of those there > > is a significant chunk of ACPI specific handling so the relevant guards > > are there anyway and the complexity is more easily justified. I have > > not intent to touch those at this time. > > Long awaited series, thanks for doing it! > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > (with some individual nit-picks that you may fix whilst applying) Thanks. Mostly so I can forget about this series, I've made the tweaks and applied the lot to the togreg branch of iio.git which will get rebased on rc1 in a few weeks time. Happy to add more tags etc or indeed drop any problematic patches if I get any more feedback in the meantime! > > Side note: We now have: array_size.h, container_of.h, hex.h, > kstrtox.h, sprintf.h. > You may start considering replacing "proxy" headers such as kernel.h > in the code. Hmm. That's more of a nice to have than this set where it's about getting 0-day to stop pestering me :) Worth doing at some point though, perhaps as part of more substantial driver clean ups. Thanks, Jonathan > > > Jonathan Cameron (24): > > iio: accel: da280: Stop using ACPI_PTR() > > iio: accel: kxcjk-1013: Move acpi_device_id table under ifdef > > CONFIG_ACPI > > iio: accel: mma9551: Drop ACPI_PTR() usage > > iio: accel: mma9553: Drop ACPI_PTR() usage > > iio: accel: mxc4005: Drop ACPI_PTR() usage > > iio: accel: mxc6255: Drop ACPI_PTR() usage > > iio: accel: stk8ba50: Drop ACPI_PTR() usage > > iio: accel: bmc150: Drop ACPI_PTR() > > iio: gyro: bmg160: Drop ACPI_PTR() usage > > iio: humidity: hts221: Drop ACPI_PTR() usage > > iio: imu: fxos8700: Drop ACPI_PTR() usage > > iio: imu: kmx61: Drop ACPI_PTR() usage > > iio: light: jsa1212: Drop ACPI_PTR() usage > > iio: light: ltr501: Drop ACPI_PTR() usage > > iio: light: rpr0521: Drop ACPI_PTR() usage > > iio: light: stk3310: Drop ACPI_PTR() usage > > iio: light: us5182d: Drop ACPI_PTR() usage > > iio: magnetometer: bmc150: Drop ACPI_PTR() usage > > iio: magnetometer: mmc35240: Drop ACPI_PTR() usage > > iio: potentiometer: max5487: Drop ACPI_PTR() usage > > iio: st_sensors: drop ACPI_PTR() and CONFIG_ACPI guards > > iio: pressure: hp206c: drop ACPI_PTR() and CONFIG_ACPI guards > > iio: light: max44000: drop ACPI_PTR() and CONFIG_ACPI guards > > iio: adc: ti-adc109s102: drop ACPI_PTR() and CONFIG_ACPI guards > > > > drivers/iio/accel/bmc150-accel-i2c.c | 2 +- > > drivers/iio/accel/bmc150-accel-spi.c | 3 +- > > drivers/iio/accel/da280.c | 2 +- > > drivers/iio/accel/kxcjk-1013.c | 33 +++++++++++----------- > > drivers/iio/accel/mma9551.c | 4 +-- > > drivers/iio/accel/mma9553.c | 4 +-- > > drivers/iio/accel/mxc4005.c | 4 +-- > > drivers/iio/accel/mxc6255.c | 4 +-- > > drivers/iio/accel/st_accel_i2c.c | 5 +--- > > drivers/iio/accel/stk8ba50.c | 4 +-- > > drivers/iio/adc/ti-adc108s102.c | 4 +-- > > drivers/iio/gyro/bmg160_i2c.c | 4 +-- > > drivers/iio/humidity/hts221_i2c.c | 4 +-- > > drivers/iio/imu/fxos8700_i2c.c | 3 +- > > drivers/iio/imu/fxos8700_spi.c | 3 +- > > drivers/iio/imu/kmx61.c | 2 +- > > drivers/iio/light/jsa1212.c | 4 +-- > > drivers/iio/light/ltr501.c | 3 +- > > drivers/iio/light/max44000.c | 6 ++-- > > drivers/iio/light/rpr0521.c | 4 +-- > > drivers/iio/light/stk3310.c | 4 +-- > > drivers/iio/light/us5182d.c | 4 +-- > > drivers/iio/magnetometer/bmc150_magn_i2c.c | 3 +- > > drivers/iio/magnetometer/bmc150_magn_spi.c | 3 +- > > drivers/iio/magnetometer/mmc35240.c | 4 +-- > > drivers/iio/potentiometer/max5487.c | 4 +-- > > drivers/iio/pressure/hp206c.c | 6 ++-- > > drivers/iio/pressure/st_pressure_i2c.c | 5 +--- > > 28 files changed, 60 insertions(+), 75 deletions(-) > > > > -- > > 2.43.0 > > > >
