On Tue, 26 Dec 2023 16:28:39 +0000 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Sun, 24 Dec 2023 16:34:46 +0200 > Petre Rodan <petre.rodan@xxxxxxxxxxxxxxx> wrote: > > > Define enum inside the honeywell,transfer-function property block. > > > > Set the correct irq edge in the example block. > > Based on the datasheet, in table 13 on page 11: > > "End-of-conversion indicator: This pin is set high when a measurement > > and calculation have been completed and the data is ready to be > > clocked out" > > > > Add description on End-of-conversion interrupt. > > > > Signed-off-by: Petre Rodan <petre.rodan@xxxxxxxxxxxxxxx> > > Signed-off-by: Andreas Klinger <ak@xxxxxxxxxxxxx> > What's the relationship between Andreas and this patch? > > Petre seems to have sent it so either Andreas should have a Co-authored-by or Co-developed-by: that is. > should be the author... Or not there at all > > Thanks, > > Jonathan > > > --- > > .../bindings/iio/pressure/honeywell,mprls0025pa.yaml | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > > index d9e903fbfd99..84ced4e5a7da 100644 > > --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > > +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > > @@ -42,6 +42,10 @@ properties: > > maxItems: 1 > > > > interrupts: > > + description: > > + Optional interrupt for indicating End-of-conversion. > > + If not present, the driver loops for a while until the received status > > + byte indicates correct measurement. > > maxItems: 1 > > > > reset-gpios: > > @@ -65,6 +69,7 @@ properties: > > 1 - A, 10% to 90% of 2^24 (1677722 .. 15099494) > > 2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874) > > 3 - C, 20% to 80% of 2^24 (3355443 .. 13421773) > > + enum: [1, 2, 3] > > $ref: /schemas/types.yaml#/definitions/uint32 > > > > vdd-supply: > > @@ -93,7 +98,7 @@ examples: > > reg = <0x18>; > > reset-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>; > > interrupt-parent = <&gpio3>; > > - interrupts = <21 IRQ_TYPE_EDGE_FALLING>; > > + interrupts = <21 IRQ_TYPE_EDGE_RISING>; > > honeywell,pmin-pascal = <0>; > > honeywell,pmax-pascal = <172369>; > > honeywell,transfer-function = <1>; > > -- > > 2.41.0 > > > >
