On Mon, Dec 25, 2023 at 07:56:24PM +0100, Krzysztof Kozlowski wrote:
> On 25/12/2023 16:13, Petre Rodan wrote:
> >>> @@ -88,6 +88,9 @@ properties:
> >>> Maximum pressure value the sensor can measure in pascal.
> >>> To be specified only if honeywell,pressure-triplet is not set.
> >>>
> >>> + spi-max-frequency:
> >>> + maximum: 800000
> >>
> >> So you miss allOf: with $ref to spi props.
> >
> > for simplicity's sake and for compatibility with the i2c devices already in use,
> > this driver does not have distinct 'compatible' properties for the i2c and spi
> > implementation.
> > this is why I just defined spi-max-frequency, used it in the spi example, but
> > not required it. just like in hsc030pa.yaml .
> >
> > without a differentiation in the 'compatible' string I don't see how your request
> > can be implemented.
>
> You cannot have different compatibles. I did not propose it. I wrote
> nothing about compatible. I wrote about missing $ref in top-level for
> spi-peripheral-props. Where do you see anything about compatible?
sorry, for one hot second I thought you want that property to be conditionally
defined, like
allOf:
- $ref: /schemas/spi/spi-peripheral-props.yaml
- if:
properties:
compatible:
contains:
const: honeywell,foo-spi
then:
properties:
spi-max-frequency:
maximum: 800000
required:
- spi-max-frequency
but I guess you only want the first two lines from here.
happy holidays,
peter
Attachment:
signature.asc
Description: PGP signature
