Re: [PATCH V2 1/3] dt-bindings: iio: adc: Add QCOM PMIC5 Gen3 ADC bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

On 11/16/2023 5:13 PM, Krzysztof Kozlowski wrote:
On 16/11/2023 04:25, Jishnu Prakash wrote:
For the PMIC5-Gen3 type PMICs, ADC peripheral is present in HW for the
following PMICs: PMK8550, PM8550, PM8550B and PM8550VX PMICs.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.

reg:
-    description: VADC base address in the SPMI PMIC register map
-    maxItems: 1
NAK.

I wrote it multiple times. You canno remove the widest constraints from
top-level property.


    '#io-channel-cells':
      const: 1
interrupts:
-    maxItems: 1
No, srsly. We went through it.


Is it fine if I add the bindings for ADC5 Gen3 in a new file? It's not just for the reg and interrupts properties, I think it would make sense to have a new file as ADC5 Gen3 is a new device combining the functions of the existing QCOM VADC and ADC_TM devices.




-    description:
+    description: |
        End of conversion interrupt.
+      - For compatible property "qcom,spmi-adc5-gen3", interrupts are defined
+        for each SDAM being used.
+
+  interrupt-names:
+    description: |
You must describe the names which also provides constraints.


I'll update this in the next patchset.

Thanks,

Jishnu



I am not going to review the rest of the file.

Best regards,
Krzysztof





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux