From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
A lot of the advantages of the automated cleanup added for locks and similar
are not that useful in IIO unless we also deal with the
iio_device_claim_direct_mode() / iio_device_release_direct_mode()
calls that prevent IIO device drivers from transitioning into buffered
mode whilst calls are in flight + prevent sysfs reads and writes from
interfering with buffered capture if it is enabled.
Relies on Peter Zilstra's conditional cleanup handling which is queued
up for the merge window in the tip tree. This series is based on
a merge of tip/master into iio/togreg.
All comments welcome. If this looks positive I'll make use of it in a
lot more drivers, but hopefully these give an idea of how it will work.
The need to always handle what happens after
iio_device_claim_direct_scoped() {} is a little irritating but the
compiler will warn if you don't do it and it's not obvious how to
let the compiler know the magic loop (hidden in the cleanup.h macros)
always runs once. Example:
iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
return 42;
}
/* Can't actually get here, but compiler moans if no return val */
return -EINVAL;
}
Assuming no show stoppers, I'll post a non RFC version next cycle and
if I get sufficiently bored over the holidays it may include a few more
users.
Jonathan Cameron (10):
iio: locking: introduce __cleanup() based direct mode claiming
infrastructure
iio: dummy: Use automatic lock and direct mode cleanup.
iio: accel: adxl367: Use automated cleanup for locks and iio direct
mode.
iio: imu: bmi323: Use cleanup handling for
iio_device_claim_direct_mode()
iio: adc: max1363: Use automatic cleanup for locks and iio mode
claiming.
iio: proximity: sx9360: Use automated cleanup for locks and IIO mode
claiming.
iio: proximity: sx9324: Use automated cleanup for locks and IIO mode
claiming.
iio: proximity: sx9310: Use automated cleanup for locks and IIO mode
claiming.
iio: adc: ad4130: Use automatic cleanup of locks and direct mode.
iio: adc: ad7091r-base: Use auto cleanup of locks.
drivers/iio/accel/adxl367.c | 261 +++++++++++----------------
drivers/iio/adc/ad4130.c | 128 ++++++-------
drivers/iio/adc/ad7091r-base.c | 25 +--
drivers/iio/adc/max1363.c | 149 +++++++--------
drivers/iio/dummy/iio_simple_dummy.c | 189 ++++++++++---------
drivers/iio/imu/bmi323/bmi323_core.c | 53 ++----
drivers/iio/industrialio-core.c | 4 +
drivers/iio/proximity/sx9310.c | 114 ++++--------
drivers/iio/proximity/sx9324.c | 107 ++++-------
drivers/iio/proximity/sx9360.c | 111 ++++--------
include/linux/iio/iio.h | 22 +++
11 files changed, 481 insertions(+), 682 deletions(-)
--
2.43.0
