On Wed, Dec 13, 2023 at 04:10:40PM +0000, Conor Dooley wrote: > On Wed, Dec 13, 2023 at 05:21:19AM -0600, David Lechner wrote: > > This adds a binding specification for the Analog Devices Inc. AD7380 > > family of ADCs. > > > > Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx> > > --- > > > > v2 changes: > > - Added maxItems to reg property > > - Replaced adi,sdo-mode property with spi-rx-bus-channels > > - Made spi-rx-bus-channels property optional with default value of 1 > > (this made the if: check more complex) > > - Changed example to use gpio for interrupt > > > > .../devicetree/bindings/iio/adc/adi,ad7380.yaml | 107 +++++++++++++++++++++ > > MAINTAINERS | 9 ++ > > 2 files changed, 116 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml > > new file mode 100644 > > index 000000000000..43d58c52f7dd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml > > @@ -0,0 +1,107 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7380.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices Simultaneous Sampling Analog to Digital Converters > > + > > +maintainers: > > + - Michael Hennerich <Michael.Hennerich@xxxxxxxxxx> > > + - Nuno Sá <nuno.sa@xxxxxxxxxx> > > + > > +description: | > > + * https://www.analog.com/en/products/ad7380.html > > + * https://www.analog.com/en/products/ad7381.html > > + * https://www.analog.com/en/products/ad7383.html > > + * https://www.analog.com/en/products/ad7384.html > > + > > +$ref: /schemas/spi/spi-peripheral-props.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - adi,ad7380 > > + - adi,ad7381 > > + - adi,ad7383 > > + - adi,ad7384 > > + > > + reg: > > + maxItems: 1 > > + > > + spi-max-frequency: > > + maximum: 80000000 > > + spi-cpol: true > > + spi-cpha: true > > + > > + spi-rx-bus-channels: > > This is now being framed as a standard property, so I think it should be > in spi-peripheral-props, no? Granted, you'd need a rather more > generalised explanation of the property in that case. > > > + description: > > + In 1-wire mode, the SDOA pin acts as the sole data line and the SDOB/ALERT > > + pin acts as the ALERT interrupt signal. In 2-wire mode, data for input A > > + is read from SDOA and data for input B is read from SDOB/ALERT (and the > > + ALERT interrupt signal is not available). > > + enum: [1, 2] > > Jonathan also mentioned specifying that this defaults to 1-wire. I > didn't see a response or that implemented. Did you miss that comment > from him? Ah, I read the patchset backwards, d'oh. I see you did in fact do both of these things. Apologies!
Attachment:
signature.asc
Description: PGP signature
