On 30/11/2023 10:36, Petre Rodan wrote: > > good morning. > > On Thu, Nov 30, 2023 at 09:31:45AM +0100, Krzysztof Kozlowski wrote: >> On 29/11/2023 18:04, Petre Rodan wrote: >>> Adds binding for digital Honeywell TruStability HSC and SSC series >>> pressure and temperature sensors. >>> Communication is one way. The sensor only requires 4 bytes worth of >>> clock pulses on both i2c and spi in order to push the data out. >>> The i2c address is hardcoded and depends on the part number. >>> There is no additional GPIO control. >>> >>> Datasheet: >>> https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-hsc-series/documents/sps-siot-trustability-hsc-series-high-accuracy-board-mount-pressure-sensors-50099148-a-en-ciid-151133.pdf [HSC] >>> Datasheet: >>> https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-ssc-series/documents/sps-siot-trustability-ssc-series-standard-accuracy-board-mount-pressure-sensors-50099533-a-en-ciid-151134.pdf [SSC] >>> Signed-off-by: Petre Rodan <petre.rodan@xxxxxxxxxxxxxxx> >> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions, under or above your Signed-off-by tag. Tag is "received", when >> provided in a message replied to you on the mailing list. Tools like b4 >> can help here. However, there's no need to repost patches *only* to add >> the tags. The upstream maintainer will do that for tags received on the >> version they apply. >> >> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. > > thank you for the clarification. > not going to lie, this entire process is overwhelming. I'm trying to generate > the least amount of noise on this very busy list and yet here I am being the > loudest one. who whould have thougth that being prudent and running two > consecutive commands of `git send-email` would produce out-of-thread patches on > your end, or that b4 or whatever you use would not pick up tags already present > for a patch? > > I'd like to thank everyone commenting on my stupid patch and rest assured that > most of the mistakes you point out are a learning lesson on the receiving side. > keep them coming and excuse the noise, it will fade away soon. > > and regarding the bindings file, there have been no changes to it since the tag. > Sure, no worries. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof