On Wed, Nov 29, 2023 at 09:47:57AM +0100, Krzysztof Kozlowski wrote: > On 29/11/2023 09:44, Petre Rodan wrote: > > > > hi, > > > > On Wed, Nov 29, 2023 at 09:04:17AM +0100, Krzysztof Kozlowski wrote: > >> On 29/11/2023 08:04, Petre Rodan wrote: > >>> Adds binding for digital Honeywell TruStability HSC and SSC series > >>> pressure and temperature sensors. > >>> Communication is one way. The sensor only requires 4 bytes worth of > >>> clock pulses on both i2c and spi in order to push the data out. > >>> The i2c address is hardcoded and depends on the part number. > >>> There is no additional GPIO control. > >> > >> Your threading is broken (not existing) since v4, making it difficult to > >> apply the patchset. Please fix it when sending v6. > > > > I'm confused. > > > > you mean the lack of 'In-Reply-To' and 'References' headers in the emails > > `git send-email` is generating? > > I've added them for v2, but was told that was a mistake [1] > > > > [1] https://lore.kernel.org/lkml/20231125191915.7f1f2dc4@jic23-huawei/ The instructions there were don't thread v2 to v1. Here, we're talking about threading within this version. > > > > I'm probably misunderstanding something. > > also, I hope v5 is flawless enough. > > No, v5 is still wrong. Patchset should be threaded. Open lore.kernel.org > and look how patchsets are organized and how your patchset is done. > > It is as simple as: > git format-patch -v6 -2 > scripts/get_maintainers.pl > git send-email v6* By default, git does the right thing, but the '--thread' option could be changed in your config. Note both commands can do the threading. If you are mucking with 'In-Reply-To' then it is probably wrong. Rob
