On Tue, 2023-11-28 at 16:58 +0100, Krzysztof Kozlowski wrote: > On 28/11/2023 16:26, Nuno Sa wrote: > > From: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > > > > This change adds support for an external amplifier to be connected in a > > Nothing improved here. > > I said "This commit/patch" so you replaced it to "change", really, read > the Submitting patches document. > And? Is this message so horrible? Yes, you did said "This commit/patch" but I thought "commit/patch" was the issue because yes, I already saw other maintainers/reviewers complaining about using those specific words but nothing really against "This change" (and I do have some messages like that). Yeah, the submitting patches document suggests to do it more like "Added a new property so bala bla ..." but I dunno every word in that document is blindly followed. Is this such a big deal in here that you had reply like I don't care? And even if you're technically right, there were better ways to say that what I have was not exactly what you asked for... Submitters should make maintainers/reviewers life easier but the other way around is equally true and nitpicky things like this are not helpful. Really... Anyways, I'll send the v3. - Nuno Sá
