RE: [PATCH] iio: adc: imx93: add four channels for imx93 adc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: 2023年11月27日 0:03
> To: Bough Chen <haibo.chen@xxxxxxx>
> Cc: lars@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>; linux-iio@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] iio: adc: imx93: add four channels for imx93 adc
> 
> On Thu, 16 Nov 2023 15:10:26 +0800
> haibo.chen@xxxxxxx wrote:
> 
> > From: Haibo Chen <haibo.chen@xxxxxxx>
> >
> > According to the spec, this ADC totally support 8 channels.
> > i.MX93 contain this ADC with 4 channels connected to pins in the
> > package. i.MX95 contain this ADC with 8 channels connected to pins in
> > the package.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx>
> Should I treat this as a fix?
> 
> If so could you reply with a fixes tag please

Yes, please help add:
Fixes: 7d02296ac8b8 ("iio: adc: add imx93 adc support")

Thanks
Haibo Chen
> 
> Thanks,
> 
> Jonathan
> 
> > ---
> >  drivers/iio/adc/imx93_adc.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/iio/adc/imx93_adc.c b/drivers/iio/adc/imx93_adc.c
> > index 9bb1e4ba1aee..4ccf4819f1f1 100644
> > --- a/drivers/iio/adc/imx93_adc.c
> > +++ b/drivers/iio/adc/imx93_adc.c
> > @@ -93,6 +93,10 @@ static const struct iio_chan_spec
> imx93_adc_iio_channels[] = {
> >  	IMX93_ADC_CHAN(1),
> >  	IMX93_ADC_CHAN(2),
> >  	IMX93_ADC_CHAN(3),
> > +	IMX93_ADC_CHAN(4),
> > +	IMX93_ADC_CHAN(5),
> > +	IMX93_ADC_CHAN(6),
> > +	IMX93_ADC_CHAN(7),
> >  };
> >
> >  static void imx93_adc_power_down(struct imx93_adc *adc)





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux