Re: [PATCH V2 3/3] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/11/2023 20:34, Jonathan Cameron wrote:
> On Thu, 16 Nov 2023 17:27:53 +0200
> Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote:
> 
>> On Thu, 16 Nov 2023 at 13:44, Krzysztof Kozlowski
>> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>>
>>> On 16/11/2023 04:26, Jishnu Prakash wrote:  
>>>> There are several files containing QCOM ADC macros for channel names
>>>> right now in the include/dt-bindings/iio folder. Since all of these
>>>> are specifically for adc, move the files to the
>>>> include/dt-bindings/iio/adc folder.
>>>>
>>>> Also update all affected devicetree and driver files to fix compilation
>>>> errors seen with this move and update documentation files to fix
>>>> dtbinding check errors for the same.
>>>>
>>>> Signed-off-by: Jishnu Prakash <quic_jprakash@xxxxxxxxxxx>
>>>> ---
>>>>  .../devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml       | 4 ++--
>>>>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 +-
>>>>  .../devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml  | 2 +-
>>>>  .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml    | 6 +++---
>>>>  arch/arm64/boot/dts/qcom/pm2250.dtsi                      | 2 +-
>>>>  arch/arm64/boot/dts/qcom/pm6125.dtsi                      | 2 +-  
>>>
>>> NAK, bindings are always separate from the other changes.  
>>
>> In this case I'd even try to appeal :-)
>> They are doing `git mv` and then fixing the failouts. I think this
>> should be fine.
> Agreed.  The only easy way around this would be to put some dummy headers
> that include the new ones in old locations temporary basis then delete them later.
> I'm fine with that if Kryzsztof prefers it that way.  Not too disruptive.

I think Rob acked it, so I am fine.

Best regards,
Krzysztof





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux