On 21/11/2023 11:00, Kim Seer Paller wrote: > Dual microwave down converter module with input RF and LO frequency > ranges from 0.5 to 32 GHz and an output IF frequency range from 0.1 to > 8 GHz. It consists of a LNA, mixer, IF filter, DSA, and IF amplifier > for each down conversion path. > > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx> > --- > V1 -> V2: Removed '|' after description. Specified the pins connected to > the GPIOs. Added additionalProperties: false. Changed node name to gpio. Why? Is this a GPIO? Your bindings title say this is a converter, not a GPIO. > Aligned < syntax with the previous syntax in the examples. > > .../bindings/iio/frequency/adi,admfm2000.yaml | 130 ++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 137 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admfm2000.yaml > > diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admfm2000.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admfm2000.yaml > new file mode 100644 > index 000000000000..92a7736c6eeb > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admfm2000.yaml > @@ -0,0 +1,130 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2023 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/frequency/adi,admfm2000.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ADMFM2000 Dual Microwave Down Converter > + > +maintainers: > + - Kim Seer Paller <kimseer.paller@xxxxxxxxxx> > + > +description: > + Dual microwave down converter module with input RF and LO frequency ranges > + from 0.5 to 32 GHz and an output IF frequency range from 0.1 to 8 GHz. > + It consists of a LNA, mixer, IF filter, DSA, and IF amplifier for each down > + conversion path. > + > +properties: > + compatible: > + enum: > + - adi,admfm2000 > + > + switch1-gpios: > + description: > + Must contain an array of 2 GPIO specifiers, referring to the GPIO pins Not much improved here - you still repeat the constraints. > + connected to the B15 and B16. > + minItems: 2 > + maxItems: 2 Instead all this: items: - description: B15 GPIO something something doing something - description: B16 GPIO something something doing some switching > + > + switch2-gpios: > + description: > + Must contain an array of 2 GPIO specifiers, referring to the GPIO pins > + connected to the L14 and K14. > + minItems: 2 > + maxItems: 2 > + > + attenuation1-gpios: > + description: > + Must contain an array of 5 GPIO specifiers, referring to the GPIO pins > + connected to the C14, C15, C16, D14, and D15. > + minItems: 5 > + maxItems: 5 > + > + attenuation2-gpios: > + description: > + Must contain an array of 5 GPIO specifiers, referring to the GPIO pins > + connected to the L15, L16, M14, M15, and M16. > + minItems: 5 > + maxItems: 5 > + Best regards, Krzysztof
