On 11/19/23 16:07, Jonathan Cameron wrote:
On Sat, 18 Nov 2023 01:06:09 +0100
Marek Vasut <marex@xxxxxxx> wrote:
The ISL76682 is very basic ALS which only supports ALS or IR mode
in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any
other fancy functionality. Document it as trivial device.
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Signed-off-by: Marek Vasut <marex@xxxxxxx>
I'm always a bit in 2 minds about trivial-devices as it doesn't
include a basic power supply. In this case vdd which I'd prefer
to see documented even on such a simple device as this.
Not everyone is going to leave it powered up all the time!
Still I'm not that fussed. Maybe it's worth allowing vdd-supply in
trivial-devices.yaml?
The hardware I have is powered all the time, so I'd be adding completely
untested code which is no less useless for me (at least right now). Lets
postpone this until there is a need for it, can we ?
I addressed all the other comments in 2/2.
