> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Wednesday, November 8, 2023 4:13 PM
> To: David Airlie <airlied@xxxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>;
> Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard
> <mripard@xxxxxxxxxx>; Thomas Zimmermann <tzimmermann@xxxxxxx>;
> Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Andi
> Shyti <andi.shyti@xxxxxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-
> Peter Clausen <lars@xxxxxxxxxx>; Lee Jones <lee@xxxxxxxxxx>; Ulf
> Hansson <ulf.hansson@xxxxxxxxxx>; Tomasz Figa <tomasz.figa@xxxxxxxxx>;
> Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>; Linus Walleij
> <linus.walleij@xxxxxxxxxx>; Thierry Reding <thierry.reding@xxxxxxxxx>; Uwe
> Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; Alessandro Zummo
> <a.zummo@xxxxxxxxxxxx>; Alexandre Belloni
> <alexandre.belloni@xxxxxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; Jiri Slaby <jirislaby@xxxxxxxxxx>; Liam
> Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>;
> Jaehoon Chung <jh80.chung@xxxxxxxxxxx>; Sam Protsenko
> <semen.protsenko@xxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-
> i2c@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx;
> linux-gpio@xxxxxxxxxxxxxxx; linux-pwm@xxxxxxxxxxxxxxx; linux-
> rtc@xxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; alsa-devel@alsa-
> project.org; linux-sound@xxxxxxxxxxxxxxx
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: [PATCH 02/17] dt-bindings: i2c: exynos5: add specific compatibles for
> existing SoC
>
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only. This works fine and
> there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> I propose to take the patch through Samsung SoC (me). See cover letter for
> explanation.
> ---
> Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++++++++-
> .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 2 +-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> index 3e52a0db6c41..c1f5d2cb7709 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> @@ -25,7 +25,15 @@ properties:
> - samsung,exynos5250-hsi2c # Exynos5250 and Exynos5420
> - samsung,exynos5260-hsi2c # Exynos5260
> - samsung,exynos7-hsi2c # Exynos7
> - - samsung,exynosautov9-hsi2c # ExynosAutoV9 and Exynos850
> + - samsung,exynosautov9-hsi2c
> + - items:
> + - enum:
> + - samsung,exynos5433-hsi2c
> + - const: samsung,exynos7-hsi2c
> + - items:
> + - enum:
> + - samsung,exynos850-hsi2c
Does this need an entry in allOf:? to indicate exynos850 also has 2 clocks?
> + - const: samsung,exynosautov9-hsi2c
> - const: samsung,exynos5-hsi2c # Exynos5250 and Exynos5420
> deprecated: true
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-
> usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-
> usi.yaml
> index a6836904a4f8..5b7ab69546c4 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> @@ -155,7 +155,7 @@ examples:
> };
>
> hsi2c_0: i2c@13820000 {
> - compatible = "samsung,exynosautov9-hsi2c";
> + compatible = "samsung,exynos850-hsi2c",
> + "samsung,exynosautov9-hsi2c";
> reg = <0x13820000 0xc0>;
> interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> --
> 2.34.1
