Please, do not send so often this big patches (~1.5kLoC!), let reviewers a bit of time, please. Since I have my message postponed, I finish review on the v1, and I believe 100% of those comments will be applicable here.
Hi Andy, v1 broke the kernel build, which was bit embarrassing as I skipped compilation on latest kernel and only tested on my embedded test bench, so I submitted v2 that early, sorry about that, I understand, won't happen again. I am not in a hurry either! Regards, Subhajit Ghosh